Request logging refactor #410
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Half-Shot
force-pushed
the
hs/logging-refactor
branch
2 times, most recently
from
d097509
to
7da88b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #412 (Based on
hs/logging-refactor, change branch before merge)This PR is quite an invasive one, but since we're planning a breaking release there isn't a better time to try. The intent here is to improve several components of the library:
Taking inspiration from Synapse and the teams bridge, this improves our Request components:
controller, which should hopefully improve types.The hope is that bridges further extend the request type for remote requests too, so that remote requests also gain their own IDs.