Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debounceRequest function #338

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add debounceRequest function #338

wants to merge 1 commit into from

Conversation

Half-Shot
Copy link
Contributor

Fixes #332

This basically allows callers to call a function on the intent multiple times and await the same outcome, which we often do for bridges.

@Half-Shot
Copy link
Contributor Author

NB I might decide to split this out to a utility class.

@Half-Shot Half-Shot requested a review from a team as a code owner September 23, 2022 11:08
tadzik
tadzik approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd expect it to ship with something else in the code already using it, so that it doesn't exist in a vacuum :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utility to debounce room creation
2 participants
@Half-Shot @tadzik