Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly refactor latestEventsUpdater #3272

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Nov 23, 2023

In an attempt to make testing the latestEventsUpdater easier, some moving around of variables and method calls.

@S7evinK S7evinK added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Nov 23, 2023
@S7evinK S7evinK requested a review from a team as a code owner November 23, 2023 18:51
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (8e4dc6b) 65.41% compared to head (9e2afb5) 65.72%.

Files Patch % Lines
roomserver/internal/input/input_latest_events.go 53.75% 29 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3272      +/-   ##
==========================================
+ Coverage   65.41%   65.72%   +0.30%     
==========================================
  Files         509      509              
  Lines       57512    57519       +7     
==========================================
+ Hits        37622    37804     +182     
+ Misses      16001    15881     -120     
+ Partials     3889     3834      -55     
Flag Coverage Δ
unittests 50.05% <53.75%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant