-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pseudoIDs] Allow displayname changes, kick users on redaction #3131
Open
S7evinK
wants to merge
24
commits into
main
Choose a base branch
from
s7evink/memberships
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
added
the
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
label
Jul 3, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
==========================================
- Coverage 64.44% 64.31% -0.14%
==========================================
Files 506 506
Lines 57011 57202 +191
==========================================
+ Hits 36743 36788 +45
- Misses 16442 16576 +134
- Partials 3826 3838 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
devonh
reviewed
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few things to allow displayname/avatar changes in pseudo ID rooms.
GetRoomsByMembership
now queries the pseudo ID keys to get all roomsmxid_mapping
incontent
, the user leaves the room or is kickedcurrent_room_state
(if needed)join
->join
) we now remove themxid_mapping
fromunsigned.prev_content
)join
->join
event and temporarily add a prev_content, so validating the event signature doesn't error because of a missingmxid_mapping
A few things we need to think about:
Considering that users can leave rooms on their own and rejoin them, we now have two join events with a
mxid_mapping
. Currently redacting the current join event results in a leave/kick, but we still have another unredactedmxid_mapping
. It's up to the client to walk theunsigned.replaces_state
field to redact other membership events containing amxid_mapping
Kicking users, on redaction of a join event, may not always be possible, as the powerlevels could have been changed to allow redactions for PL50, but kicking is only allowed for PL100. How do we handle those cases? Temporarily fake/update the powerlevels to allow kicking?