Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin pytest #27858

Merged
merged 1 commit into from Mar 4, 2024
Merged

pin pytest #27858

merged 1 commit into from Mar 4, 2024

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Mar 4, 2024

PR summary

Pytest 8.1.0 just released and broke most of our CI.

PR checklist

@rcomer rcomer requested a review from ksunden March 4, 2024 15:11
@rcomer rcomer added this to the v3.8.4 milestone Mar 4, 2024
@rcomer rcomer added the CI: testing CI configuration and testing label Mar 4, 2024
@rcomer
Copy link
Member Author

rcomer commented Mar 4, 2024

Looks like the version has been yanked (for different reasons) so maybe we don't need this?
pytest-dev/pytest#12069

@tacaswell tacaswell merged commit cb8c484 into matplotlib:main Mar 4, 2024
43 of 44 checks passed
@tacaswell
Copy link
Member

Better safe.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 4, 2024
@rcomer rcomer deleted the pip-pytest branch March 4, 2024 17:49
tacaswell added a commit that referenced this pull request Mar 4, 2024
…858-on-v3.8.x

Backport PR #27858 on branch v3.8.x (pin pytest)
@ksunden
Copy link
Member

ksunden commented Mar 4, 2024

I just ran on pytest git version to check, but it looks like the problem was fixed by pytest-dev/pytest#12074 which was merged shortly following the yanking of 8.1.0 and was backported to the release branch. Thus I do not think we need to take any further action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: testing CI configuration and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants