Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: add missing method to ColormapRegistry #24111

Merged
merged 5 commits into from Oct 8, 2022
Merged

FIX: add missing method to ColormapRegistry #24111

merged 5 commits into from Oct 8, 2022
+68 −9

Commits on Oct 7, 2022

  1. FIX: add missing method to ColormapRegistry 

    After putting pending deprecations on `cm.get_cmap` we discovered that
downstream libraries (pandas) were using the deprecated method to normalize
between `None` (to get the default colormap), strings, and Colormap instances.
This adds a method to `ColormapRegistry` to do this normalization.

This can not replace our internal helper due to variations in what exceptions
are raised.

Closes matplotlib#23981
    @tacaswell
    tacaswell committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    fcf1c0c View commit details
    Browse the repository at this point in the history

  2. DOC: remove note about ColormapRegistry being experimental 

    We are committed now!
    @tacaswell
    tacaswell committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    3f99c20 View commit details
    Browse the repository at this point in the history

  3. DOC: fix formatting and wording 

    Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
    @tacaswell @timhoffm
    tacaswell and timhoffm committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    b8bdcf8 View commit details
    Browse the repository at this point in the history

  4. MNT: fix test name 

    Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
    @tacaswell @timhoffm
    tacaswell and timhoffm committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    d0a240a View commit details
    Browse the repository at this point in the history

  5. MNT: raise ValueError and TypeError rather than KeyError

    @tacaswell
    tacaswell committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    4f8ece4 View commit details
    Browse the repository at this point in the history