Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention gr backend in docs. #14706

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Mention gr backend in docs. #14706

merged 1 commit into from
Jul 7, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 6, 2019

PR Summary

Closes #7950. The text for gr was paraphrased from http://gr-framework.org/ and http://gr-framework.org/about.html.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful new section.

Not merging yet, because I'm not sure why the tests fail.

@jklymak
Copy link
Member

jklymak commented Jul 7, 2019

I think we merged something w a flake8 error.

@jklymak
Copy link
Member

jklymak commented Jul 7, 2019

...or something happened to flake8 so it no longer works

@timhoffm
Copy link
Member

timhoffm commented Jul 7, 2019

pydocstyle 4.0 was released yesterday (https://pypi.org/project/pydocstyle/#history). I'm quite sure this is the reason for the failure (though I did not check what exactly goes wrong there).

@anntzer
Copy link
Contributor Author

anntzer commented Jul 7, 2019

basically flake8-pydocstyle doesn't support (yet) the last version of pydocstyle, although there's a PR open on their repo to fix that

@timhoffm
Copy link
Member

timhoffm commented Jul 7, 2019

Since this is doc-only. I don't think flake8 would check the changes anyway. So merging without waiting for the flake8-docstring fix (#14710).

@timhoffm timhoffm merged commit db90685 into matplotlib:master Jul 7, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 7, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 7, 2019
timhoffm added a commit that referenced this pull request Jul 7, 2019
…706-on-v3.1.1-doc

Backport PR #14706 on branch v3.1.1-doc (Mention gr backend in docs.)
timhoffm added a commit that referenced this pull request Jul 7, 2019
…706-on-v3.1.x

Backport PR #14706 on branch v3.1.x (Mention gr backend in docs.)
@anntzer anntzer deleted the gr branch July 7, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention gr as a third party backend
4 participants