Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Upgrade pytest again #14420

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Conversation

jkseppan
Copy link
Member

@jkseppan jkseppan commented Jun 2, 2019

See pytest-dev/pytest#5358

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jkseppan jkseppan changed the title Upgrade pytest again MAINT: Upgrade pytest again Jun 2, 2019
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we fine with bumping pytest, or should we simply leave pytest!=4.6.0 in?

@QuLogic
Copy link
Member

QuLogic commented Jun 3, 2019

Yes, I don't understand why the minimum needs to be bumped here either.

@jkseppan
Copy link
Member Author

jkseppan commented Jun 3, 2019

I don't see why not use the latest pytest: it's not a requirement for users but what we run ourselves in CI. But I suppose specifying !=4.6.0 is effectively the same, just more complex for the people who will look at the files in the future.

@jkseppan
Copy link
Member Author

jkseppan commented Jun 3, 2019

The tests pass now, and it seems that both Travis and Appveyor are using pytest 4.6.1.

@timhoffm timhoffm merged commit 005acc0 into matplotlib:master Jun 3, 2019
@QuLogic QuLogic added this to the v3.2.0 milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants