Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_imshow_pil on Windows. #14419

Merged
merged 1 commit into from Jun 7, 2019
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 2, 2019

test_imshow_pil currently fails on Windows, but this was not detected
because PIL is not installed on the Appveyor CI so the test is skipped.

Noted while working on #13077.
The Pillow issue is python-pillow/Pillow#3823.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

test_imshow_pil currently fails on Windows, but this was not detected
because PIL is not installed on the Appveyor CI so the test is skipped.
@jkseppan
Copy link
Member

jkseppan commented Jun 7, 2019

Is there a reason that we don't install PIL on Appveyor, or could it be added in .appveyor.yml?

@anntzer
Copy link
Contributor Author

anntzer commented Jun 7, 2019

I think originally because the appveyor tests were extremely slow and a real bottleneck.
OTOH I guess it is nice to have at least one test instance without Pillow to show that Matplotlib indeed works fine in its absence.

@jkseppan
Copy link
Member

jkseppan commented Jun 7, 2019 via email

@dstansby dstansby added this to the v3.2.0 milestone Jun 7, 2019
@dstansby dstansby merged commit f803777 into matplotlib:master Jun 7, 2019
@anntzer anntzer deleted the imshowpilpath branch June 7, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants