FIX: add missing method to ColormapRegistry #24111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Oct 6, 2022
|
I'm working on a fix to the docs build failure 🤦🏻 . |
tacaswell
force-pushed
the
add_missing_cmap_registry_method
branch
from
329983d
to
a2f2db9
Compare
After putting pending deprecations on `cm.get_cmap` we discovered that downstream libraries (pandas) were using the deprecated method to normalize between `None` (to get the default colormap), strings, and Colormap instances. This adds a method to `ColormapRegistry` to do this normalization. This can not replace our internal helper due to variations in what exceptions are raised. Closes matplotlib#23981
We are committed now!
tacaswell
force-pushed
the
add_missing_cmap_registry_method
branch
from
a2f2db9
to
3f99c20
Compare
timhoffm
reviewed
Oct 7, 2022
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
QuLogic
approved these changes
Oct 7, 2022
|
OK, switch to raising |
tacaswell
force-pushed
the
add_missing_cmap_registry_method
branch
from
2f96205
to
a2dc64a
Compare
tacaswell
force-pushed
the
add_missing_cmap_registry_method
branch
from
a2dc64a
to
4f8ece4
Compare
jklymak
approved these changes
Oct 8, 2022
|
@QuLogic I'll leave for you to merge in case you want to squash it, or @tacaswell can squash merge.... |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 8, 2022
QuLogic
added a commit
that referenced
this pull request
Oct 8, 2022
…111-on-v3.6.x Backport PR #24111 on branch v3.6.x (FIX: add missing method to ColormapRegistry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
After putting pending deprecations on
cm.get_cmapwe discovered that downstream libraries (pandas) were using the deprecated method to normalize betweenNone(to get the default colormap), strings, and Colormap instances. This adds a method toColormapRegistryto do this normalization.This can not replace our internal helper due to variations in what exceptions are raised.
Closes #23981
I opted to edit the existing deprecation message as this seemed like the lest-bad option.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).