Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed image on save #294

Closed
wants to merge 1 commit into from
Closed

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jan 16, 2021

This is an attempt to embed the Image state on Notebook save (JupyterLab only for now, we can maybe do something similar in Jupyter Notebook classic).

The logic here is to:

  • Hook up to the "save" event of the Notebook
  • Go through all outputs and find matplotlib widgets
  • Replace the widget output into plain html image

See #150 #16

@martinRenou
Copy link
Member Author

This doesn't work yet. I am opening the PR as a draft for heads up/

This was referenced Jan 16, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2021

This pull request introduces 2 alerts when merging 8587f22 into ac0a7c3 - view on LGTM.com

new alerts:

  • 2 for Missing variable declaration

@martinRenou
Copy link
Member Author

Might be replaced by #300

@martinRenou
Copy link
Member Author

Closing as outdated. We will try another approach for saving a static representation of the plot #343

@martinRenou martinRenou deleted the embed_image branch September 14, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant