Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to GH workflow to reset demo #3580

Merged
merged 2 commits into from May 10, 2024
Merged

Updates to GH workflow to reset demo #3580

merged 2 commits into from May 10, 2024

Conversation

pavish
Copy link
Member

@pavish pavish commented May 10, 2024

Related to #3577, #3579

Fixes line break issues with 'Wait until all pods are removed' step

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish enabled auto-merge May 10, 2024 10:35
@pavish
Copy link
Member Author

pavish commented May 10, 2024

I'm going to merge this PR without review since the workflow file needs to be updated in develop for it to run and to be able to test it. I'll request a retrospective review once I test this thoroughly.

@pavish pavish added this pull request to the merge queue May 10, 2024
Merged via the queue into develop with commit 79e7b52 May 10, 2024
33 checks passed
@pavish pavish deleted the action_reset_demo branch May 10, 2024 11:22
@pavish pavish restored the action_reset_demo branch May 10, 2024 12:46
@pavish pavish mentioned this pull request May 10, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant