Navigate to linked table via cell context menu

[hitenvidhani]

Fixes #2350

Screenshots

On clicking a record which is inked

On clicking a record which is not linked

On clicking column name which is linked

On clicking column name not linked

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[seancolsen]

Thanks @hitenvidhani this is a good start. I have some changes to request:

• In ColumnHeaderContextMenu.svelte

  • Don't use router.goto. Instead, use LinkMenuItem like we are using in RowCell.svelte.

  • You have:

    {$_('open')}
    <Identifier>{column.name}</Identifier>
    {$_('table')}

    This structure might be problematic when translated into other languages and thus does not follow best-practices for i18n. Apologies that we don't yet have any documented code standards which explain this. (We only recently enabled i18n.) The problem here is that some languages might follow different grammatical structures to translate this same text and the words might become rearranged or split depending on context. For this reason, translation needs to take place at a less granular level. We need to translate pieces of text at a higher level than this.

    For this particular string you'll need to make use of the RichText.svelte component. Look at the documentation within the component to understand how it works, and check other usages of it too. You'll need to add a new string to src/i18n/languages/en/dict.json like this:

    {
      // ...
      "open_named_table": "Open [tableName] table",
      // ...
    }

    Then pass that string into RichText.svelte with the other props and child components as necessary.

  • In that string above, don't use the column name. Instead use the the table name.

• In RowCell.svelte, you've added code which uses the following expression:

  $recordSummaries.get(String(column.id))?.get(String(value))

  Because this expression is also present higher up in the component, it would be nice to extract up into a common recordSummary variable that gets used in both places. This would improve code cleanliness.

[hitenvidhani]

extract up into a common recordSummary variable that gets used in both places.

Throws lint error hence making this change
175:36 error 'recordSummary' is already declared in the upper scope on line 105 column 6 @typescript-eslint/no-shadow

[hitenvidhani]

same reason to keep the variable as recordName and not recordSummary

[seancolsen]

I pushed 9609d37 which fixes this problem at the lower scope instead of the higher. This way we get the preferred name across more lines of the file. And we use the rs name in a very small scope.

[seancolsen]

Thanks @hitenvidhani.

I added a few other commits to clean things up. Please look over them and make sure you understand them. Ask questions if anything I did seems concerning or doesn't make sense.

[hitenvidhani]

Thank you @seancolsen .
Could you please clarify how to sort imports? I followed this guide https://github.com/mathesar-foundation/mathesar/blob/develop/mathesar_ui/README.md and still they weren't sorted with format or lint.

Also I don't see these features on the demo site https://demo.mathesar.org/, is it only after the release it would reflect here?

[seancolsen]

Good questions, @hitenvidhani

• how to sort imports

  I use the "Organize Imports" action in VS Code. I have a keyboard shortcut set to do this. At some point I'd really like to get some tooling set up in our repo which does this for us. Ideally it would be something that integrates with Prettier so that we when run Prettier the imports are automatically sorted. I you are interested in working on that it could be a nice little self-contained project. I can help clarify the requirements if this is confusing.

• demo site

  We update it manually after each release. The develop branch is not as stable as our releases. Like, we might have mid-cycle bugs that crop up during feature development. We make an effort to fix bugs like that during our QA phase before each release. So we don't want to run the demo site off the develop branch because such regressions could give people a bad impression of Mathesar.

[hitenvidhani]

Sure @seancolsen
I did a bit of research and it looks like we'd have to use the plugin prettier-plugin-svelte and add specific rules for the files in .prettierrc. It would be great if you could clarify the requirements further.

[seancolsen]

@hitenvidhani I opened #3542 with some clearer requirements. We can continue to discuss there.