-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another regression test for recursive_msonable
behavior
#672
Conversation
This PR adds another regression test for `recursive_msonable` behavior in `jsanitize` to prevent breaking of things in the future. I also ensured the test suite runs if pydantic isn't installed.
recursive_msonable
behaviorrecursive_msonable
behavior
Warning Rate Limit Exceeded@Andrew-S-Rosen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 41 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Thanks, @shyuep! I think this should be safe for a new release whenever you feel is appropriate. I have tested pymatgen and a few other repos. |
This PR adds another regression test for
recursive_msonable
behavior injsanitize
to prevent breaking of things in the future.I also ensured the test suite runs if pydantic isn't installed.