Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing kwargs in internal calls of jsanitize #660

Merged
merged 2 commits into from Apr 18, 2024

Conversation

Andrew-S-Rosen
Copy link
Contributor

@Andrew-S-Rosen Andrew-S-Rosen commented Apr 17, 2024

Identical to #657.

@shyuep, the rollback also reverted my minor but important fix to jsanitize. I reinstated it here.

Summary by CodeRabbit

  • Enhancements
    • Improved the JSON sanitization process to handle objects in lists or NumPy arrays more effectively.

Copy link

coderabbitai bot commented Apr 17, 2024

Walkthrough

The update involves enhancing the jsanitize function within the monty/json.py module by adding a new parameter recursive_msonable. This addition aids in the recursive sanitization process of objects in lists or NumPy arrays, improving the function's flexibility and depth in handling complex data structures.

Changes

File Change Summary
monty/json.py Added recursive_msonable parameter to jsanitize for improved recursive sanitization of objects.

Poem

🐰🌟
In the code where data hops around,
A tiny change does profound abound.
With recursive_msonable now in play,
Our data's clean, come what may.
Oh, how neatly every byte lays!
🎉🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Fix jsanitize Fix missing kwargs being passed in jsanitize Apr 17, 2024
@Andrew-S-Rosen Andrew-S-Rosen changed the title Fix missing kwargs being passed in jsanitize Fix missing kwargs in internal calls of jsanitize Apr 17, 2024
@shyuep shyuep merged commit e0b72dd into materialsvirtuallab:master Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants