Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of datetime in jsanitize #491

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Fix handling of datetime in jsanitize #491

merged 3 commits into from
Apr 10, 2023

Conversation

Andrew-S-Rosen
Copy link
Contributor

@Andrew-S-Rosen Andrew-S-Rosen commented Apr 9, 2023 •
edited

Currently, the jsanitize() command in monty throws an error if strict=True and a datetime object is supplied. It's better if we just handle datetime objects directly in jsanitize given how often they crop up anyway.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Fix handling of datetime Fix handling of datetime in jsanitize Apr 9, 2023
@Andrew-S-Rosen Andrew-S-Rosen mentioned this pull request Apr 9, 2023
Closed
@Andrew-S-Rosen
Copy link
Contributor Author

@shyuep --- this is ready to merge at your convenience. Thanks!

@shyuep shyuep merged commit 9349f64 into materialsvirtuallab:master Apr 10, 2023
10 checks passed
@shyuep
Copy link
Contributor

shyuep commented Apr 10, 2023

Thanks Andrew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Andrew-S-Rosen @shyuep