Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Added support for tuples, namedtuples (both from collections and typing), sets, frozensets and OrderedDict's in MSONable, MontyEncoder and MontyDecoder #100

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

WIP Added support for tuples, namedtuples (both from collections and typing), sets, frozensets and OrderedDict's in MSONable, MontyEncoder and MontyDecoder #100

wants to merge 16 commits into from

Commits on Jan 14, 2020

  1. Added is_namedtuple method to test whether an object is a namedtuple … 

    …in collections.py.

Unit test for above method.
    @davidwaroquiers
    davidwaroquiers committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    0755e76 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/materialsvirtuallab/monty

    @davidwaroquiers
    davidwaroquiers committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    f259b94 View commit details
    Browse the repository at this point in the history

  3. Added (partial) support for tuple and namedtuples in json.py. 

    Unit tests for tuple and namedtuple serialization.
    @davidwaroquiers
    davidwaroquiers committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    92246a7 View commit details
    Browse the repository at this point in the history

  4. Added support for tuple, namedtuples and OrderedDict in json.py. 

    Unit tests for tuple, namedtuple and OrderedDict serialization.
Works with MSONable class as well as with MontyEncoder and MontyDecoder.
    @davidwaroquiers
    davidwaroquiers committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    680461d View commit details
    Browse the repository at this point in the history

  5. Fixed namedtuple support for python versions < 3.7, for which default 

    values were not possible.
    @davidwaroquiers
    davidwaroquiers committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    9a57714 View commit details
    Browse the repository at this point in the history

  6. Disable pylint's check on unexpected keyword argument 'defaults'.

    @davidwaroquiers
    davidwaroquiers committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    41f4463 View commit details
    Browse the repository at this point in the history

  7. Disable pylint's check on unexpected keyword argument 'defaults'.

    @davidwaroquiers
    davidwaroquiers committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    d5527b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Added is_NamedTuple to check whether object is a class generated from… 

    … typing.NamedTuple.

Unit tests for is_NamedTuple.
    @davidwaroquiers
    davidwaroquiers committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    3f3c029 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Added validate_NamedTuple to check whether the items in a NamedTuple … 

    …have the correct type.

Unit tests for validate_NamedTuple.
    @davidwaroquiers
    davidwaroquiers committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    6866658 View commit details
    Browse the repository at this point in the history

  2. Changed validate_NamedTuple to accept subclass of the types as valid … 

    …field types for the different fields.
    @davidwaroquiers
    davidwaroquiers committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b67e6e6 View commit details
    Browse the repository at this point in the history

  3. Changed validate_NamedTuple to accept subclass of the types as valid … 

    …field types for the different fields.
    @davidwaroquiers
    davidwaroquiers committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    e233d4c View commit details
    Browse the repository at this point in the history

  4. Ignoring pytest import for mypy.

    @davidwaroquiers
    davidwaroquiers committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    465467d View commit details
    Browse the repository at this point in the history

  5. Changed "builtins" to "@builtins" in the serialization of tuples, nam… 

    …edtuples, etc ... in order to avoid potential clashes with the builtins package.
    @davidwaroquiers
    davidwaroquiers committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    3ed73cc View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Added serialization of typing.NamedTuple's.

    @davidwaroquiers
    davidwaroquiers committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    7e823a9 View commit details
    Browse the repository at this point in the history

  2. Added serialization of sets.

    @davidwaroquiers
    davidwaroquiers committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    d982c3b View commit details
    Browse the repository at this point in the history

  3. Fixed pycodestyle, pylint, mypy, ...

    @davidwaroquiers
    davidwaroquiers committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    04e0513 View commit details
    Browse the repository at this point in the history