Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValueError in SpacegroupAnalyzer.get_symmetrized_structure() if spglib returns no symmetries #2724

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Raise ValueError in SpacegroupAnalyzer.get_symmetrized_structure() if spglib returns no symmetries #2724

merged 5 commits into from
Nov 7, 2022

Commits on Nov 7, 2022

  1. mypy

    @janosh
    janosh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    940e9fe View commit details
    Browse the repository at this point in the history

  2. setup.py pin mypy==0.982 

    since https://github.com/python/mypy/releases/tag/v0.990 raises many new errors
    @janosh
    janosh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    9f821bc View commit details
    Browse the repository at this point in the history

  3. raise ValueError in SpacegroupAnalyzer.get_symmetrized_structure() if… 

    … spglib returns no symmetries
    @janosh
    janosh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    817e69f View commit details
    Browse the repository at this point in the history

  4. add SpacegroupAnalyzerTest.test_get_symmetry() to cover new ValueError

    @janosh
    janosh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    6085eab View commit details
    Browse the repository at this point in the history

  5. add link to GH PR

    @janosh
    janosh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    689bf2e View commit details
    Browse the repository at this point in the history