Fix tensor mapping (#2720)

materialsproject · Nov 7, 2022 · 511d1ff · 511d1ff
1 parent dd884cf
commit 511d1ff
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/pymatgen/core/tensors.py b/pymatgen/core/tensors.py
@@ -1050,8 +1050,8 @@ def __init__(self, tensors: Sequence[Tensor] = (), values: Sequence = (), tol: f
         """
         if len(values) != len(tensors):
             raise ValueError("TensorMapping must be initialized with tensors and values of equivalent length")
-        self._tensor_list = tensors
-        self._value_list = values
+        self._tensor_list = list(tensors)  # needs to be a list
+        self._value_list = list(values)  # needs to be a list
         self.tol = tol
 
     def __getitem__(self, item):

diff --git a/pymatgen/core/tests/test_tensors.py b/pymatgen/core/tests/test_tensors.py
@@ -302,7 +302,11 @@ def test_tensor_mapping(self):
         assert reduced[tkey] == "test_val"
         # Test empty initialization
         empty = TensorMapping()
-        assert empty._tensor_list == ()
+        assert empty._tensor_list == []
+
+        # test adding to empty tensor mapping
+        empty[tkey] = 1
+        assert empty[tkey] == 1
 
     def test_populate(self):
         test_data = loadfn(os.path.join(PymatgenTest.TEST_FILES_DIR, "test_toec_data.json"))