Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python 3.8 support #951

Merged
merged 8 commits into from
May 24, 2024
Merged

drop python 3.8 support #951

merged 8 commits into from
May 24, 2024

Conversation

rkingsbury
Copy link
Collaborator

@rkingsbury rkingsbury commented May 14, 2024

Drop support for python 3.8 as it reached end of life some time ago. Add python 3.12 to the CI testing in its place.

EDIT: cannot easily add python 3.12 at this time because montydb does not support it. Will address separately / later.

Closes #917

@rkingsbury rkingsbury added the breaking includes breaking changes label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (2559136) to head (1fc0e33).

Current head 1fc0e33 differs from pull request most recent head 3f2fdb6

Please upload reports for the commit 3f2fdb6 to get more accurate results.

Files Patch % Lines
src/maggma/stores/open_data.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   81.26%   81.33%   +0.07%     
==========================================
  Files          46       46              
  Lines        3971     3971              
==========================================
+ Hits         3227     3230       +3     
+ Misses        744      741       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury self-assigned this May 15, 2024
@rkingsbury rkingsbury merged commit f944d10 into materialsproject:main May 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking includes breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop python 3.8
1 participant