Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change cleint -> resource in aws tests #574

Merged
merged 1 commit into from Mar 5, 2022

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Mar 4, 2022

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #574 (67d33ee) into main (c33381e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files          40       40           
  Lines        2794     2794           
=======================================
  Hits         2490     2490           
  Misses        304      304           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d6c73...67d33ee. Read the comment docs.

@munrojm
Copy link
Member

munrojm commented Mar 4, 2022

Does explicitly specifying us-east-1 here impact anything?

@jmmshn
Copy link
Contributor Author

jmmshn commented Mar 5, 2022

no but I think moto wants you to do this because sometimes missing regions gives warnings and defaults to us-east

@munrojm munrojm merged commit 11e7168 into materialsproject:main Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants