Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header processing abilities to certain Resource classes #569

Merged
merged 5 commits into from Feb 15, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Feb 15, 2022

This PR allows the ReadOnlyResource to take in a HeaderProcessor object to manipulate header information for each request.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #569 (3e2a6a8) into main (b14a5b2) will increase coverage by 0.09%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   89.02%   89.11%   +0.09%     
==========================================
  Files          40       40              
  Lines        2743     2794      +51     
==========================================
+ Hits         2442     2490      +48     
- Misses        301      304       +3     
Impacted Files Coverage Δ
src/maggma/api/resource/read_resource.py 96.38% <88.23%> (-2.30%) ⬇️
src/maggma/api/resource/aggregation.py 92.85% <90.00%> (-1.59%) ⬇️
src/maggma/api/resource/__init__.py 100.00% <100.00%> (ø)
src/maggma/api/resource/core.py 80.00% <100.00%> (+1.42%) ⬆️
src/maggma/api/resource/post_resource.py 97.82% <100.00%> (+0.04%) ⬆️
src/maggma/api/resource/submission.py 87.50% <100.00%> (+0.24%) ⬆️
src/maggma/api/resource/utils.py 100.00% <100.00%> (ø)
src/maggma/core/drone.py 92.42% <0.00%> (ø)
src/maggma/cli/distributed.py 100.00% <0.00%> (ø)
src/maggma/stores/gridfs.py 94.35% <0.00%> (+0.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd881f...3e2a6a8. Read the comment docs.

@munrojm munrojm merged commit c33381e into main Feb 15, 2022
@munrojm munrojm deleted the header_processing branch April 7, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant