Use built-in github annotation output for stylelint
#30165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like annotation was added correctly - https://github.com/mastodon/mastodon/pull/30165/files#diff-06774996d17ab60d2e8f656c3a88a4ed22274a7af2c13ea0a910f786d07d132bR13 - will leave that error in place for now. If we want to merge, I'll remove. |
ClearlyClaire
previously approved these changes
May 3, 2024
mjankowski
force-pushed
the
stylelint-github-annotations
branch
from
cb745c3
to
c15e5be
Compare
|
Removed the error-only commit, now just the config change. |
ClearlyClaire
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent runs are showing the deprecated node version warning - https://github.com/mastodon/mastodon/actions/runs/8930704927 - and it looks like the current tool is no longer maintained? xt0rted/stylelint-problem-matcher#461 - but stylelint has a built-in github formatter - stylelint/stylelint#6150 - and we can use that directly instead.
(Including an intentional CSS error in this PR to watch and see it run correctly and add annotations...)