low_delivery queue v2 #30150
Open
low_delivery queue v2 #30150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
reviewed
May 25, 2024
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class ActivityPub::LowPriorityDeliveryWorker < ActivityPub::DeliveryWorker | |||
| sidekiq_options queue: 'pull', retry: 8, dead: false | |||
| sidekiq_options queue: 'low_delivery', retry: 8, dead: false | |||
There was a problem hiding this comment.
This may be over-analyzing, but I interpret low_delivery as "this is something which is unlikely to be delivered". Would low_priority or nonessential or relaxed or something (?) ...
There was a problem hiding this comment.
I originally named it for "Low priority delivery".
As I know, This sends these kind of activity
- Delete Actor
- Forward remotes' Delete activity
As it sends local "Delete Actor" activity, nonessential doesn't reflect about it.
In my opinion, I'd like low_priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake of #20216... please just close both PRs if this isn't worth the price.
Will require a lot of admins to add the additional queue.