Skip to content
This repository has been archived by the owner on May 5, 2024. It is now read-only.

Allow Automatic release notes in Releases #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jyejare
Copy link

@jyejare jyejare commented Mar 28, 2023

Adding a support for Automatic Release notes in Github Release !

@xavt
Copy link

xavt commented Nov 3, 2023

how do you even view the diff !!?
why even having a single line js file on such open source projects?
at least have a readable workable source file and a minifier process if that's absolutely necessary.
(more criticizing of @marvinpinto original file; I spent too long to get the diff bits of the one-line patch;)

here are some diffs, not sure how to best present it:

  1. before:

    ,t=u.getInput("files",{required:!1});return

    after:

    generateReleaseNotes:JSON.parse(u.getInput("generate_release_notes",{required:!0}))},t=u.getInput("files",{required:!1});return

  2. before:

    u.endGroup(),r.data.upload_url})))(n,{owner:r.repo.owner,repo:r.repo.repo,tag_name:i,name:e.releaseTitle?e.releaseTitle:i,draft:e.draftRelease,prerelease:e.preRelease,body:d});yield

    after:

    u.endGroup(),r.data.upload_url})))(n,{owner:r.repo.owner,repo:r.repo.repo,tag_name:i,name:e.releaseTitle?e.releaseTitle:i,draft:e.draftRelease,prerelease:e.preRelease,body:d,generate_release_notes:i.generateReleaseNotes});yield

  3. before:

    "target_commitish":{"type":"string"}},"url":"/repos/:owner/:repo/releases"},"createStatus":{"method":"POST","params":{"context":{"type":"string"},

    after:

    "target_commitish":{"type":"string"},"generate_release_notes":{"type":"boolean"}},"url":"/repos/:owner/:repo/releases"},"createStatus":{"method":"POST",

that's it for the changes; it's legit

Copy link

@xavt xavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist/index.js would have been better of as un minified...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants