Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global CSS improvements #166

Closed
wants to merge 2 commits into from
Closed

Global CSS improvements #166

wants to merge 2 commits into from

Conversation

martpie
Copy link
Owner

@martpie martpie commented Feb 4, 2021

Attemps to solve #146

  • Can it even work?
  • Make it work everywhere
  • Add rules instead of updating rules?
  • Overall code review and simplification

temp, reminder, ignore the following:

Goals of the PR:

  • Support global CSS import from node_modules
  • Support CSS modules from node_modules

@fabianishere
Copy link

Hi @martpie,

Thank for your work on this package! Did you manage to get this PR working and would you still be willing to have this functionality (support for Global CSS imports) in next-transpile-modules?

I managed to get Patternfly 4 (which uses Global CSS imports) to work with Next.js using the following changes: fabianishere@5f61c10. I'd be willing to help getting Global CSS imports to work with this package.

@martpie
Copy link
Owner Author

martpie commented May 20, 2021

any PR is definitely welcome! I checked quickly your work yesterday ;)

What would be awesome is if you could copy the test changes of this PR to make sure it works as expected :]

@martpie
Copy link
Owner Author

martpie commented May 21, 2021

-> #210

@martpie martpie closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants