simple_op_store: hash view/operation data directly #734
Conversation
Ralith
force-pushed
the
push-b3e19dc016af471e8c577aeeb5e0269d
branch
2 times, most recently
from
2404c2a
to
c7ed2e8
Compare
|
On second thought I've about run out of patience updating callsites. WIll probably reprise this with a custom impl tomorrow. |
There was a problem hiding this comment.
Oh, it would be nice with a longer description for "simple_op_store: hash view/operation data directly". It would be good to answer at least these questions:
Why are you doing this?
Because depending on the serialized format means that hashes change if we change the format, and also that it's possible that an upgrade to the protobuf library results in a different serialized form and thus a different hash.
What happens to existing repos?
Since the hashes are only used for identity (not for integrity checking), it should not break existing repo.
|
Just a random comment. I thought Hasher could be implemented as a serde Serializer, but that turned out to be not good idea. impl Serializer requires lengthy boilerplate code, and maybe it would be a bit trickier to ensure HashMap has stable order. |
Ralith
force-pushed
the
push-b3e19dc016af471e8c577aeeb5e0269d
branch
5 times, most recently
from
5b72287
to
6ed6953
Compare
Ralith
force-pushed
the
push-b3e19dc016af471e8c577aeeb5e0269d
branch
from
6ed6953
to
5b5d7f1
Compare
|
Dropped the churn, added support for newtype structs to the macro, added a helper function, and expanded usage to local_backend. I also documented a protocol for enums so hopefully we can keep implementations consistent with eachother and with future improvements to the macro.
Yeah, see also RustCrypto/utils#2 for prior discussion in the ecosystem. |
|
Aw, need rustc 1.63 for the convenient |
Ralith
force-pushed
the
push-b3e19dc016af471e8c577aeeb5e0269d
branch
from
5b5d7f1
to
23bdddf
Compare
Ralith
force-pushed
the
push-b3e19dc016af471e8c577aeeb5e0269d
branch
from
23bdddf
to
71dd10e
Compare
Ralith
force-pushed
the
push-b3e19dc016af471e8c577aeeb5e0269d
branch
from
71dd10e
to
f3ac695
Compare
Ralith
force-pushed
the
push-b3e19dc016af471e8c577aeeb5e0269d
branch
from
f3ac695
to
e8f2db3
Compare
Decouples view/operation IDs from serialized forms, which are not necessarily stable. Not breaking as these IDs are persistent, never recomputed or used for integrity checking.
Insulates identifiers from the unstable serialized form.
Ralith
force-pushed
the
push-b3e19dc016af471e8c577aeeb5e0269d
branch
from
e8f2db3
to
134c946
Compare
Product of discussion in #700. First commit could be replaced with a manual impl for the enum, saving a fair bit of churn at the cost of being slightly more error prone. No strong opinion about which would be preferable.