Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow for GitHub Actions #3

Merged
merged 1 commit into from Dec 1, 2022
Merged

Add CI workflow for GitHub Actions #3

merged 1 commit into from Dec 1, 2022

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Dec 1, 2022

It's based on the workflow file of bit-lite (https://github.com/martinmoene/bit-lite/blob/master/.github/workflows/ci.yml), so it probably should work without further changes.

As a side effect, this PR also contributes to martinmoene/nonstd-lite-project#70 by providing a workflow that already has the newer version of actions/checkout.

It's based on the workflow file of bit-lite.
@martinmoene martinmoene merged commit 1e7a784 into martinmoene:master Dec 1, 2022
@striezel striezel deleted the add-ci-workflow branch December 1, 2022 19:13
@striezel
Copy link
Contributor Author

striezel commented Dec 1, 2022

It did not work as expected (see https://github.com/martinmoene/optional-fun-lite/actions/runs/3595731162/jobs/6055579375 and others). It looks like the header file from optional-lite is required for compilation, too:

[ 33%] Building CXX object test/CMakeFiles/optional-fun-lite-cpp17.t.dir/optional-fun-main.t.cpp.o
<command-line>: fatal error: ../../optional-lite/include/nonstd/optional.hpp: No such file or directory
compilation terminated.

This means that the the CI workflows will probably need an additional step that pulls in the code from optional-lite.

@martinmoene
Copy link
Owner

@striezel

It has been a long time since I've looked at optional-fun-lite.
There are several tests, but I can't remember how mature it is (or not).
Setting up a Readme will help with discovering that too :)

Thank you very much for all the PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants