Remove the Parser cache #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafrech
approved these changes
Jan 29, 2020
|
I think this is good to merge to. Do you mind doing the rebase? |
|
Not at all. I'll have it done in just a second. |
Because the cache is no longer used field-by-field to fetch data, there's significantly less value in keeping it. Combined with the fact that each parser instantiation was already clearing the cache to avoid a security bug ( marshmallow-code#371 ), the cache is no longer actually used at all in most (any?) contexts. Remove the cache and all of the machinery associated with it (Parser._clear_cache, Parser._clone, and relevant checks). Resolves marshmallow-code#374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the cache is no longer used field-by-field to fetch data, there's significantly less value in keeping it. Combined with the fact that each parser instantiation was already clearing the cache to avoid a security bug ( #371 ), the cache is no longer actually used at all in most (any?) contexts.
Remove the cache and all of the machinery associated with it (Parser._clear_cache, Parser._clone, and relevant checks).
Resolves #374
If there's some case I'm not aware of in which the cache is really useful, that's fine. But based on my reading, I don't think it really does anything anymore, so I'm proposing its removal.