fix #336: detecting relationship as nullable=False #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdealiLoKo
reviewed
Sep 7, 2022
| @@ -348,7 +348,7 @@ def _add_relationship_kwargs(self, kwargs, prop): | |||
| nullable = True | |||
| for pair in prop.local_remote_pairs: | |||
| if not pair[0].nullable: | |||
| if prop.uselist is True: | |||
| if not self.DIRECTION_MAPPING[prop.direction.name]: | |||
There was a problem hiding this comment.
This should be handling 2 cases:
- For anything which has a list - we expect an empty list - and so nullable=False
- And for anything which has a FK on the table itself - we should consider the nullable from the FK (MANYTOONE case)
if not pair[0].nullable:
if prop.uselist is True or self.DIRECTION_MAPPING[prop.direction.name] is False:
nullable = False
continue
MANYTOONE case:
class Book:
...
author_id = Column(Integer, ForeignKey('author.id'), nullable=False)
author = relationship('Author', lazy='selectin')MANYTOMANY case with uselist=True:
class Book:
...
author = relationship('Author', secondary=book_author, lazy='selectin', uselist=True)MANYTOMANY case with uselist=False:
class Book:
...
author = relationship('Author', secondary=book_author, lazy='selectin', uselist=False)Can we add testcases for various direction X uselist scenarios ?
There was a problem hiding this comment.
Hi @AbdealiJK ,
Have updated the changes based on the feedback in comment
indiVar0508
force-pushed
the
fix_336
branch
from
8adcc14
to
ee0d2a5
Compare
|
@indiVar0508 could you please rebase this? @AbdealiLoKo review welcome after rebase. Thanks guys! |
lafrech
requested changes
Feb 28, 2023
tests/test_conversion.py
Outdated
| @@ -354,6 +354,49 @@ class ModelWithArray(Base): | |||
| assert field.dump_only is True | |||
|
|
|||
|
|
|||
| class TestRelationShipKwarg: | |||
tests/test_conversion.py
Outdated
| def test_many_to_one_relationship_kwarg(self, models): | ||
| default_converter = ModelConverter() | ||
|
|
||
| rel = models.Student.__mapper__.get_property("current_school") |
There was a problem hiding this comment.
Please don't use get_property but .attrs (see #495).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #336,
using direction mapping to decide if nullable is to be set False or not
pytest result for new branch:
94 passed, 55 warningspytest in master :
94 passed, 55 warnings