Fix included_data and data["included"] type consistency. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 7, 2019 21:01
included resource objects in the json api is a list but the schema implementation needs it to be a dict indexed by type and id. The new test checks that loading and then dumping with the same schema object on a dict with an included resource works. It is needed for Flask-rest-jsonapi that re-uses schema between load and dump.
AdrianVandierAst
changed the title
multimeric
reviewed
Nov 8, 2019
tests/test_schema.py
Outdated
| { | ||
| "type": "people", | ||
| "id": "1", | ||
| "first_name": fake.first_name(), |
There was a problem hiding this comment.
These attributes should be inside the "attributes": {} key. I'm a tad surprised that this works.
There was a problem hiding this comment.
Corrected in the last commit
|
I will response here to #133 (comment) Schema.included_data is consistently a dict for loading and dumping. And the "included" part of the json api object is consistently a list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included resource objects in the json api are in a list but the schema implementation
needs it to be a dict indexed by type and id.
The new test checks that loading and then dumping with the same schema object on a
dict with an included resource works. It is needed for Flask-rest-jsonapi that re-uses schema between load and dump.