Refactor openapi converter #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2020
Merged
Bangertm
approved these changes
Jul 21, 2020
| name="body", | ||
| required=False, | ||
| description=None | ||
| self, schema, *, location, name="body", required=False, description=None |
There was a problem hiding this comment.
I'm torn about what to do with the name parameter. It's only used when location=="body" and it's default value is tied to that case - I presume to guarantee a valid parameter object if the user doesn't enter anything. Seems like it's adding a little extra confusion to this method but I'm not sure anything better can be done.
|
Thanks @Bangertm for taking the time to review this. I think I'm gonna merge this and open an issue about the location mapping. |
Also remove dead code: location can't be body in fields2parameters
lafrech
force-pushed
the
refactor_openapi_converter
branch
from
0737f6b
to
eaceb0b
Compare
kam193
added a commit
to kam193/flask-apispec
that referenced
this pull request
Oct 11, 2020
1. Rename 'default_in' (marshmallow-code/apispec#526) 2. Dict schema: convert it to object and handle special case 'body', since prior used method no longer exists (marshmallow-code/apispec#581)
sloria
added a commit
to jmcarp/flask-apispec
that referenced
this pull request
Oct 25, 2020
* Compatibility with apispec 4 1. Rename 'default_in' (marshmallow-code/apispec#526) 2. Dict schema: convert it to object and handle special case 'body', since prior used method no longer exists (marshmallow-code/apispec#581) * Drop support for apispec < 4, Python < 3.6 Supporting different apispec version requires different logic for each of them. New apispec requires Python >= 3.6 * Remove unused imports * Update tox.ini * Update changelog * Drop Python 3.5 support apispec no longer supports 3.5 Co-authored-by: Steven Loria <sloria1@gmail.com>
jollysahil
pushed a commit
to levrofin/flask-apispec
that referenced
this pull request
Sep 12, 2023
* Compatibility with apispec 4 1. Rename 'default_in' (marshmallow-code/apispec#526) 2. Dict schema: convert it to object and handle special case 'body', since prior used method no longer exists (marshmallow-code/apispec#581) * Drop support for apispec < 4, Python < 3.6 Supporting different apispec version requires different logic for each of them. New apispec requires Python >= 3.6 * Remove unused imports * Update tox.ini * Update changelog * Drop Python 3.5 support apispec no longer supports 3.5 Co-authored-by: Steven Loria <sloria1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #526.
Implements refactor discussed in #500 and #526.
I did not address handling webargs field dicts (#500 (comment)). It can be done later anytime (perhaps easier once MA2 is dropped).
Once #526 is merged, I can rebase this for a clearer diff.