Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a streamer reader #106

Merged
merged 1 commit into from Mar 8, 2020

Conversation

nwalfield
Copy link

This MR adds a streaming reader similar to the streaming writer that is in write/encoder.rs.

@nwalfield
Copy link
Author

The CI failure happens using the nightly version of rustc. Specifically, the error message is:

error: trait objects without an explicit `dyn` are deprecated
  --> src/decode.rs:58:32
   |
58 |     fn cause(&self) -> Option<&error::Error> {
   |                                ^^^^^^^^^^^^ help: use `dyn`: `dyn error::Error`
   |
note: lint level defined here
  --> src/lib.rs:61:5
   |
61 |     warnings,
   |     ^^^^^^^^
   = note: #[deny(bare_trait_objects)] implied by #[deny(warnings)]
error: aborting due to previous error

I think that this is a preexisting problem and not due to my patch.

@marshallpierce
Copy link
Owner

Thanks! I'll take a look as soon as I can.

@marshallpierce
Copy link
Owner

Working on this in #122 -- unfortunately we need more complex state management in case the delegate writer does short reads and we end up with partial base64 chunks, etc. But, I'm poking at it, and it shouldn't be too awful to rearrange.

@marshallpierce marshallpierce merged commit f80579b into marshallpierce:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants