Update fast-glob to v3 to fix globbing for non-ASCII file #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: It has some breaking changes from v2. globby is not yet supported v3 so we had better to wait until be updated, but any problem was not found at the moment.
|
I'm continue working to upgrade an upstream package: sindresorhus/globby#126 |
yhatt
force-pushed
the
master
branch
2 times, most recently
from
e79b30c
to
302c083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #108. fast-glob v3 has more stable regex matcher for non-ASCII path (generated by updated micromatch v4).
NOTE: It has some breaking changes from v2. globby v9 is not yet supported fast-glob v3 so we had better to wait until be updated.