Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make esm imports work without /esm #211

Closed
wants to merge 1 commit into from
Closed

Conversation

janpe
Copy link

@janpe janpe commented Nov 15, 2022

Currently you have to use import {} from 'date-fns-tz/esm'; for esm to work. After this change the /esm is unnecessary.

@michaelwittwer
Copy link

@janpe I based on your PR and additional added the types field as described here (https://nodejs.org/api/packages.html#package-entry-points > Community Conditions Definitions), so you might want to close your PR if you are ok with the additional changes in #212

@janpe
Copy link
Author

janpe commented Dec 1, 2022

@janpe I based on your PR and additional added the types field as described here (https://nodejs.org/api/packages.html#package-entry-points > Community Conditions Definitions), so you might want to close your PR if you are ok with the additional changes in #212

Sounds good!

@janpe janpe closed this Dec 1, 2022
@marnusw
Copy link
Owner

marnusw commented Jan 30, 2023

Fixed via #212. Released in v2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants