Improve link validation with lychee-action #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsojramos
previously approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Overall I think it looks good! It caught a lot of things that we didn't before, lets ship it! 🚀
We'll just need to fix these errors that we are getting such as:
- ✗ [404] https://www.jumo.world/careers | Network error: Not Found fix: jumo careers link #265
- ✗ [404] https://platforme.com/jobs | Network error: Not Found fix: platforme careers link #264
- ✗ [404] https://www.symantec.com/about/careers | Network error: Not Found remove: symantec #267
- ✗ [404] https://www.alter-solutions.com/pt-pt/ | Network error: Not Found fix: alter & add career page #266
- [ ] Error: R] http://www.alticelabs.com/ | Network error: No status codeThis one is probably just an occasional error. - ✗ [404] http://devscope.net/AboutUs/Joinus.aspx | Network error: Not Found fix: devscope careers link #268
- ✗ [404] https://cloudmobility.io/career | Network error: Not Found - Remove cloudmobility.io #269 269
Replaced awesome-bot validation to lychee-action to improve stability and validation quality. Added dependabot rule to keep improving validation.
vpereira01
force-pushed
the
betterlinkvalidation
branch
from
7cb7836
to
bcf93e1
Compare
afonsojramos
approved these changes
Mar 31, 2022
|
@marmelo can you approve this? 👀 PS: Maybe we should reduce the number of approvals to 1 |
marmelo
approved these changes
Apr 22, 2022
|
Lets try if this is better than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced awesome-bot validation with lychee-action to improve stability and validation quality. You can notice that some links are incorrect and awesome-bot has not give us that feedback. (404 errors).
Some limitations/issues/annoyances:
✗ [404] https://www.symantec.com/about/careers | Network error: Not Foundmeans HTTP 404 Not Found⧖ [TIMEOUT] https://skyhour.com/ | Timeout✗ [ERROR] http://www.alticelabs.com/ | Network error: No status codeis parsed by the UI and shows asError: R] http://www.alticelabs.com/ | Network error: No status codeThis change can be updated to have both jobs running in parallel instead of just having one so this can be evaluated.
Tell what you guys think.