Fix useGetManyReference loading state detection #5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Feb 17, 2021
fzaninotto
requested changes
Feb 18, 2021
| state.admin.references.oneToMany[relatedTo].ids; | ||
| (state.admin.references.oneToMany[relatedTo] && | ||
| state.admin.references.oneToMany[relatedTo].ids) || | ||
| null; |
There was a problem hiding this comment.
if the problem is undefined vs null, I'd rather you change the isDataLoaded to use != null instead of !== null - less risk of breaking things.
| { | ||
| admin: { | ||
| references: { | ||
| oneToMany: { ids: [] }, |
There was a problem hiding this comment.
same. Also, you test with a list of empty ids, you miss a test wit ha list of non-empty ids
| { | ||
| admin: { | ||
| references: { | ||
| oneToMany: {}, |
There was a problem hiding this comment.
this is not the normal shape of the state. there is a key representing the reference between reference and oneToMany
fzaninotto
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.