Fix simple example doesn't run on CodeSandbox #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinH
changed the title
djhi
requested changes
Feb 17, 2021
examples/simple/package.json
Outdated
| @@ -42,6 +42,7 @@ | |||
| "ra-input-rich-text": "^3.9.0", | |||
| "ra-language-english": "^3.9.0", | |||
| "ra-language-french": "^3.9.0", | |||
| "ra-ui-materialui": "^3.9.0", | |||
There was a problem hiding this comment.
ra-ui-materialui is a dependency of react-admin, this shouldn't be necessary
There was a problem hiding this comment.
Yes that's what I thought as well. I'll try to update all the other dependencies then .
|
I think the problem is in the CodeSandbox side; If you clone the defautl react-admin codesandbox, it works... |
|
I don't really know what was wrong but after updating all ra-related packages, it works fine. I've updated my PR. |
fzaninotto
approved these changes
Feb 17, 2021
|
Except some of the packages don't have a version 3.12... |
|
Indeed 🙈 |
|
your JSON is invalid. I suggest you test your patch before pushing it. |
|
Sorry for the inconvenience. 😞 |
fzaninotto
changed the title
fzaninotto
approved these changes
Feb 19, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to fix the Codesandbox for the Simple example which is currently broken.
Here's an example codesandbox with the fix implemented in this PR: https://codesandbox.io/s/funny-colden-7p1in