Add scrollToTop on key navigation links #5905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
scrollToTop
branch
from
882e5d9
to
03d337e
Compare
|
Switching to RFR |
jdemangeon
reviewed
Feb 15, 2021
djhi
requested changes
Feb 15, 2021
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
djhi
approved these changes
Feb 15, 2021
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
React-router doesn't manage scroll changes on navigation. As a consequence, when users click on an item low in the menu, or on the pagination controls, the new content may reveal up hidden in the non-visible area of the page. This is disturbing for end users.
On the other hand, the page should not scroll to top everywhere, and especially not when using the back button, applying filters, or switching tabs.
Solution
Supersedes #5891