Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle arrays in ReferenceArrayField filter #5887

Merged
merged 2 commits into from Feb 19, 2021
Merged

Handle arrays in ReferenceArrayField filter #5887

merged 2 commits into from Feb 19, 2021

Conversation

srosset81
Copy link
Contributor

Closes #5871

@srosset81 srosset81 mentioned this pull request Feb 9, 2021
Closed
djhi
djhi requested changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind adding some tests for it?

@srosset81
Copy link
Contributor Author

@djhi Done :-)

@fzaninotto
Copy link
Member

This is a new feature, and as such you should PR against next rather than master

@srosset81 srosset81 changed the base branch from master to next February 16, 2021 17:33
@srosset81 srosset81 requested a review from djhi February 16, 2021 17:33
@fzaninotto fzaninotto merged commit 011d109 into marmelab:next Feb 19, 2021
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.13 milestone Feb 19, 2021
@srosset81 srosset81 deleted the patch-2 branch February 19, 2021 22:44
This was referenced Mar 9, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi Awaiting requested review from djhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.

Allow the filter prop of ReferenceArrayField to handle arrays
3 participants
@srosset81 @fzaninotto @djhi