Changed dynamic tags to add data-marko-key and to selfclose properly #1499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For dynamic split components,
data-marko-key
was not being added and you could not access data from that template. This came to light because of the change we did tobody-only-if
which we moved to be a dynamic component.Split up beginElementDynamic and added data-marko-key when component is in browser.
I also fixed the selfclosing tags using a library to see which fields are self-closing and added those properly.
Cleaned up the redundant params also.
Added tests for each case, for both empty tags and non empty
Added a test for self-closing.
Checklist: