Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent serializing input for legacy split widgets #1497

Merged
merged 1 commit into from Feb 10, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

In Marko 3 split components do not have access to their input, however modern split components do. This PR prevents serializing input for legacy split components to increase performance in that case.

This is a subset of f4f89c9

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #1497 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
- Coverage   90.51%   90.50%   -0.01%     
==========================================
  Files         352      352              
  Lines       12582    12586       +4     
==========================================
+ Hits        11388    11391       +3     
- Misses       1194     1195       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2063f2d...4fde672. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 192d3af into master Feb 10, 2020
@DylanPiercey DylanPiercey deleted the prevent-serialize-state-split-legacy-widgets branch February 26, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant