Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed dynamic tags to add data-marko-key and to selfclose properly #1499

Merged
merged 1 commit into from Feb 12, 2020

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Feb 12, 2020

Description

For dynamic split components, data-marko-key was not being added and you could not access data from that template. This came to light because of the change we did to body-only-if which we moved to be a dynamic component.
Split up beginElementDynamic and added data-marko-key when component is in browser.

I also fixed the selfclosing tags using a library to see which fields are self-closing and added those properly.

Cleaned up the redundant params also.

Added tests for each case, for both empty tags and non empty
Added a test for self-closing.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@agliga agliga self-assigned this Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #1499 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   90.50%   90.47%   -0.03%     
==========================================
  Files         352      352              
  Lines       12583    12593      +10     
==========================================
+ Hits        11388    11394       +6     
- Misses       1195     1199       +4     
Impacted Files Coverage Δ
src/runtime/html/AsyncStream.js 89.13% <0.00%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc90708...f2a2aa3. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 0339255 into master Feb 12, 2020
@agliga agliga deleted the dynamic-tags-data-id branch February 12, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants