Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix hr after list #2809

Merged
merged 1 commit into from May 30, 2023
Merged

fix: fix hr after list #2809

merged 1 commit into from May 30, 2023

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented May 18, 2023

Marked version: v4.2.3 and later

Markdown flavor: Markdown.pl

Description

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented May 18, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 3:25pm

@azmy60 azmy60 changed the title fix: incorrect formatting of list and hr fix: matching behaviour of incorrect list and hr formatting to CommonMark May 20, 2023
UziTech
UziTech approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UziTech UziTech changed the title fix: matching behaviour of incorrect list and hr formatting to CommonMark fix: fix hr after list May 30, 2023
@UziTech UziTech merged commit efc40df into markedjs:master May 30, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 30, 2023
@semantic-release-bot
chore(release): 5.0.4 [skip ci]
5adcd53 
## [5.0.4](v5.0.3...v5.0.4) (2023-05-30)

### Bug Fixes

* Add Unicode punctuations ([#2811](#2811)) ([b213f02](b213f02))
* fix hr after list ([#2809](#2809)) ([efc40df](efc40df))
* Replace custom `repeatString` function with `repeat()` ([#2820](#2820)) ([72ee2d6](72ee2d6))
@calculuschild calculuschild mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

@styfle styfle styfle approved these changes

@calculuschild calculuschild calculuschild approved these changes

@joshbruce joshbruce Awaiting requested review from joshbruce

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown is not formatting correctly starting from v4.2.3
4 participants
@azmy60 @UziTech @styfle @calculuschild