Release v1.2.0 #1765
Release v1.2.0 #1765
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/pzhqpxs4x |
|
Ya just need to make sure you pull the changes in master after this PR is merged, then run |
|
Would you please? Have to mess it up from lack of practice. (Been in PHP deployment land.) |
|
We could probably remove the checkboxes for the following:
Since we have the bot, the minified file should always be up to date. |
|
What do you guys think about moving to semantic release. I think we talked about it before and decided to wait until after v1.0. |
|
I haven't used it before but it sounds good to me 👍 Would it be better to change to squash merge at the same time so we don't need to waste time with commit messages in PRs, just the merged commit message? |
|
ya or we could use commitlint to enforce commit messages. I tend to prefer squashing though. |
|
The reason why I dislike commit lint is that it discourages outside collaboration, especially new users who don't understand Lets do squash merging + semantic release 🚀 |
|
Thought we already were - soon as we hit 1.0 the expectation would be minor (new feature, non-BC) and patch (bug fixes). ?? Think some of the roadmap notes are still available in the projects tab. I'm a good example of what @styfle is talking about. I don't use Git CLI because I typically don't have a need for features beyond what I get from GitHub Desktop. I've debated about switching to Squash to reduce number of commits recorded (if I read up on it properly) but still haven't. |
|
Great! I switched to squash merging for PRs going forward 👍 @UziTech Do you want to enable semantic release since you're more familiar with it?
|
|
Ya I'll create a PR shortly to use semantic release. |
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Release Notes
Features
Fixes
Dependencies
Documentation
Publisher
$ npm versionhas been run.masterwith correct version number.$ npm publishhas been run.Note: If merges to
masteroccur after submitting this PR and before running$ npm pubishyou should be able toupstream/master(git pull upstream master) into the branch holding this version,$ npm run buildto regenerate theminfile, andCommitter
In most cases, this should be someone different than the publisher.
package.jsonhas been updated (see PUBLISHING.md).marked.min.jshas been updated; or,