New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow GFM spec on EM and STRONG delimiters #1686
Commits on May 21, 2020
Commits on May 29, 2020
-
Added a check for the previous character to the *em* Tokenizer. Needed to pass any tests where the em block starts with a punctuation character (e.g. commonmark example 368)
-
Commits on May 30, 2020
Commits on Jun 12, 2020
-
Properly handle reflinks that should be escaped
Modifies the em rule after the block tokens are generated to detect known reflinks and skip over them so they don't get mistakenly italicized.
-
-
Commits on Jun 17, 2020
-
Moved logic into Tokenizer. No longer injecting Reflinks
Reflinks are replaced with the string 'aaaa' of equal length to hide any asterisks or underscores that might have been inside, since these should not be included. Then, the resulting string is matched to the em regex. The positions of the captures are then used on the original string.
-
Fixes examples 391, 397, 399, 400, 401, 431, 443, 475, 476, 479, and 480
-
-
-
Commits on Jun 18, 2020
-
Remove redundant regex symbols
Found a few more cases of redundant symbols in addition to fixes suggested during review.
Commits on Jun 20, 2020
Commits on Jun 30, 2020
-
Merge pull request #1 from UziTech/mask-reflinks
mask reflinks in a separate function
-
-
Commits on Jul 2, 2020
-
Fix unrestricted "any character" for REDOS
And remove redundant unused capture group.
Commits on Jul 8, 2020
-
Beginning and End delimiters for EM and Strong must be searched in a separate regex to work without lookbehinds. This invalidates the regex that skips over blocks (code, html, etc.) that take precedence over EM or Strong blocks. Getting around this means we must now mask not only reflinks, but all enclosed blocks which were previously just skipped over in the Regex. Add one check for overlapping Strong block when testing EM, now passes Commonmark 390 and 471
-
-
Commits on Jul 9, 2020
-
Co-authored-by: Tony Brix <tony@brix.ninja>
-
Co-authored-by: Tony Brix <tony@brix.ninja>
-
-
Merge branch 'EmphasisFixes' of https://github.com/calculuschild/marked…
… into EmphasisFixes