Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move demo to docs #1161

Merged
merged 13 commits into from Mar 26, 2018
Merged

Move demo to docs #1161

merged 13 commits into from Mar 26, 2018

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 25, 2018

This PR adds a demo page to the docs.
Note: this is continued work from #64

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • CI is green (no forced merge required).
  • Merge PR

@UziTech
Copy link
Member

UziTech commented Mar 25, 2018

We should probably also link to the demo page in the docs/README.md

@styfle styfle requested a review from joshbruce March 26, 2018 00:35
@styfle
Copy link
Member Author

styfle commented Mar 26, 2018

@UziTech I almost forgot!

I made a bunch of changes including "Add link to demo from readme"

Thanks 👍

@styfle styfle added the category: docs Documentation changes label Mar 26, 2018
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshbruce
Copy link
Member

Might be nice to make the two READMEs the same. Feels weird to me to have the README on the main repo - then see a more robust and complete one on the site; especially given the main README is the one posted to NPM.

The links and everything should be able to remain the same.

@joshbruce joshbruce merged commit a92eb65 into markedjs:master Mar 26, 2018
@styfle styfle deleted the www-demo branch March 26, 2018 13:17
@styfle
Copy link
Member Author

styfle commented Mar 26, 2018

@joshbruce Yes I understand this might be a little confusing. But the idea is to not be publishing MB of data to npm because users who run npm install --save marked typically aren't referencing the README.md that they just downloaded.

However, it is a good starting point for people coming to the github page or npm page so they at least see one example usage and a link to the full docs.

Maybe the confusion can be avoided if we rename /docs/README.md to /docs/INDEX.md?

@joshbruce
Copy link
Member

joshbruce commented Mar 26, 2018

@styfle: That's fair, and pretty understandable. I think I'm looking at it from the perspective of what is the minimum information a new developer would need or want to get started and optionally dive into higher levels of complexity.

So, I think the README.md could be used without having a duplicated file in the /docs. The concept of the README.md being the locus of documentation seems to be the way GitHub and NPM operate; therefore, not having two files would make the most sense in my book.

zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants