Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commonmark] make html comments, html inlines, html blocks and links compliant #1135

Merged
merged 79 commits into from Apr 10, 2018

Conversation

Feder1co5oave
Copy link
Contributor

@Feder1co5oave Feder1co5oave commented Mar 8, 2018

Description

Parenthesis in links

Backslash escapes in links

HTML

BREAKING-CHANGES:

See commit messages (look for "BREAKING CHANGE")
This deserves a minor version bump.

TODOs:

Non-compliance with commonmark:

See commit messages (look for "NON-COMPLIANT")

Contributor

  • Test(s) exist to ensure functionality and minimize regression
  • new feature has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

non-compliant: allow `--` inside html comments.
adjust inline tag rule accordingly.
Disallow colons in tag names
BREAKING CHANGE: inline markdown is not parsed inside html blocks.
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
[commonmark] make html comments, html inlines, html blocks and links compliant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment