Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃毀[Experimenting]: Refactoring marked js馃毀 #1102

Closed
wants to merge 17 commits into from
Closed

馃毀[Experimenting]: Refactoring marked js馃毀 #1102

wants to merge 17 commits into from

Commits on Feb 28, 2018

  1. Move marked to top

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    be82a73 View commit details
    Browse the repository at this point in the history

  2. Extract method of valid src check

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    0e00700 View commit details
    Browse the repository at this point in the history

  3. Rename valid src check

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    fb28a95 View commit details
    Browse the repository at this point in the history

  4. Notes

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    02200d7 View commit details
    Browse the repository at this point in the history

  5. Ah-ha!

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    8e1f2c4 View commit details
    Browse the repository at this point in the history

  6. Initial PR

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    0741381 View commit details
    Browse the repository at this point in the history

  7. Caught by the linter, whoops.

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    f49c570 View commit details
    Browse the repository at this point in the history

  8. Update opt question

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    e1897c8 View commit details
    Browse the repository at this point in the history

  9. Update marked() docblock

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    ad96e64 View commit details
    Browse the repository at this point in the history

  10. Move lexer to second position

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    db0f752 View commit details
    Browse the repository at this point in the history

  11. Move regex to second position, not defined yet errors - whoops

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    a4f97cc View commit details
    Browse the repository at this point in the history

  12. Move Parser to third position 

    After the lexer is run, the parser goes next, the InlineLexer is not used by Marked or the Lexer, only seems to be the Parser.
    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    b988e85 View commit details
    Browse the repository at this point in the history

  13. Leave InlineLexer in fourth position

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    1ea2bc8 View commit details
    Browse the repository at this point in the history

  14. Move all variables and functions to just after Marked

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    10384e5 View commit details
    Browse the repository at this point in the history

  15. Why are some inside the object and others aren't?

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    22f5f45 View commit details
    Browse the repository at this point in the history

  16. Notes on functions

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    9ce2430 View commit details
    Browse the repository at this point in the history

  17. Linting works. 馃榾

    Josh Bruce committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    ca78f78 View commit details
    Browse the repository at this point in the history