Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown is not formatting correctly starting from v4.2.3 #2735

Closed
arman-g opened this issue Feb 15, 2023 · 7 comments · Fixed by #2809
Closed

Markdown is not formatting correctly starting from v4.2.3 #2735

arman-g opened this issue Feb 15, 2023 · 7 comments · Fixed by #2809
Labels
category: headings category: lists L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue

Comments

@arman-g
Copy link

arman-g commented Feb 15, 2023

Marked version:
v4.2.3 and later

Describe the bug
Some of the markdown is not formatting correctly (see the reproduce section below) starting from version 4.2.3. All the versions prior to that are formatting correctly.

To Reproduce
Please see the Marked Demo link below.

  1. Marked Demo
  2. Expected behavior
    Should format the markdown correctly.

@UziTech
Copy link
Member

UziTech commented Feb 16, 2023

Looks like this was broke by #2655

@UziTech UziTech added L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue category: lists category: headings labels Feb 16, 2023
@UziTech
Copy link
Member

UziTech commented Feb 16, 2023

This can be easily fixed by formatting the markdown correctly. Block level elements should have a blank line above and below them. Adding a blank line above the bottom line fixes it. demo

@arman-g
Copy link
Author

arman-g commented Feb 16, 2023

This can be easily fixed by formatting the markdown correctly. Block level elements should have a blank line above and below them. Adding a blank line above the bottom line fixes it. demo

That worked well, thanks!

@calculuschild
Copy link
Contributor

This can be easily fixed by formatting the markdown correctly.

@UziTech is this working as intended then? Seems the issue occurred due to invalid syntax?

@UziTech
Copy link
Member

UziTech commented May 13, 2023

I think this is still technically a bug because it does not do the same thing as CommonMark even though the markdown is not well formatted.

@azmy60
Copy link
Contributor

azmy60 commented May 17, 2023

Can I take this one?

@UziTech
Copy link
Member

UziTech commented May 17, 2023

@azmy60 sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: headings category: lists L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants